Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to plonk 0.8.2 #6

Merged
merged 4 commits into from
Nov 25, 2021
Merged

Update to plonk 0.8.2 #6

merged 4 commits into from
Nov 25, 2021

Conversation

MiguelDD1
Copy link

@MiguelDD1 MiguelDD1 commented Nov 22, 2021 •
edited
Loading

Changes

  • dusk-plonk updated to 0.8.2 as a dependency. We are using the tag v0.8.2-polygon-1.
  • Fix dependency issues with rand & libp2p (snow conflict).
  • Fix indentation & UTs.
  • Fix crates.io.path

Key files to review

  • Cargo.toml uses patch section to override the plonk dep.
  • Crate kate
    • It uses allocate feature to integrate with plonk on std.
    • New testnet::public_params fn to set the public params up from a seed.

@MiguelDD1 MiguelDD1 self-assigned this Nov 22, 2021
@linear
Copy link

linear bot commented Nov 22, 2021

MAT-3320 Upgrade `dusk-plonk` to `0.8.2`

Upgrade that library to 0.8.2.

@MiguelDD1 MiguelDD1 mentioned this pull request Nov 22, 2021
Closed
5 tasks
@MiguelDD1 MiguelDD1 marked this pull request as ready for review November 22, 2021 10:18
prabal-banerjee
prabal-banerjee approved these changes Nov 23, 2021
View reviewed changes
Copy link

@prabal-banerjee prabal-banerjee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments to improve my understanding about the changes. Looks good to be merged.

@prabal-banerjee
Copy link

Changes look good and nothing breaking. Let's go ahead with the merge.

@MiguelDD1 MiguelDD1 merged commit 0c92099 into da-poc-upgrade-3.0 Nov 25, 2021
@MiguelDD1 MiguelDD1 deleted the feature/MAT-3320/update_plonk branch November 25, 2021 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prabal-banerjee prabal-banerjee prabal-banerjee approved these changes

@imyourm8 imyourm8 Awaiting requested review from imyourm8

Assignees

@MiguelDD1 MiguelDD1

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MiguelDD1 @prabal-banerjee